Presentation Screenshots Download Support Development Forum    
   

Welcome to the Community Forum.

Here you can discuss with other users or with the author, suggest new features, report bugs, ask for filters creation or correction, etc. Select the forum you wish to read or post below :

Forum
Forum > Development & Bug report > Please create official GitHub repository

Pages : [1] Add a reply
User info Please create official GitHub repository
V@no
Avatar
Feb 28 2016, 11:04 pm
Hello.

Please create official repository on GitHub (and link to it instead of google code page) so we can fork and send pull requests with modifications.

Thank you.
Post #1
Edit
Cyan
Avatar
Mar 12 2016, 12:15 am
I created a github account and copied the project there.
https://github.com/cyan06/automatic-save-folder

I also did it on sourceforge and will continue commit on sourceforge too to keep the "revision number" as I was used to.
https://sourceforge.net/projects/automatic-save-folder/
Note that github is one commit behind (soureforge has r129 while github has r128)

I don't know how to use git yet, and I will have to learn how the commit, push and merge are working.
I might not answer or merge your push quickly after you do it as I don't have lot of time and rarely check what's happening here. But I'll try to update it for e10s.


Roadmap:
What I plan, or would like to be done in priority, if other developers pull some requests and update the addon:
- Update the deprecated functions, like the prefManager. see below.
- Keep the old methods for users using old version of firefox. Don't force users to update firefox if they don't want to.
- Enable (it's commented) the path creation if the folder doesn't exist.
- Prevent empty folders to be created if the user cancel the download.
- Revert the suggested paths list if the user cancel the download in order to keep "last used path" informations.

Next major version of the addon can require specific Firefox version, but for now I would like to keep old version compatible.


Then, I'll focus on updating the way it works, rewrite methods and re-use them instead of duplicating in multiple js files.
Add sqlite and object/class methods to manage the filters.

Things which needs fixes:
- If you know how to read the filename from the HTTP request header, we could remove the timer reset in right-click mode. It will allow the addition of a new menu to specify/rename the filename.
- If you know how to read the file's information from the webpage, we could remove the need of "always ask" for all filetype.


I wanted to make individual settings per filter in v2.0 but I don't know if I will ever have time to reach this version.



Two deprecated functions to replace:
Quote :
DEPRECATION WARNING: DownloadLastDir.getFile is deprecated. Please use getFileAsync instead.
You may find more details about this deprecation at: https://developer.mozilla.org/en-US/docs/Mozilla

Deprecated.jsm:79:0
DEPRECATION WARNING: nsIContentPrefService is deprecated. Please use nsIContentPrefService2 instead.
You may find more details about this deprecation at: https://developer.mozilla.org/en-US/docs/XPCOM_Interface_Reference/nsIContentPrefService2
Post #2
Edit
V@no
Avatar
Mar 31 2016, 3:44 am
Thank you very much.

I use and highly recommend Source Tree program to work with Github:
https://www.sourcetreeapp.com/

Very easy to use and almost no git knowledge required.
Post #3
Edit
Cyan
Avatar
Apr 9 2016, 11:53 am
Thank you,
I'll try it.
Edit: seems to require account registration and license, etc.
Someone else recommended tortoise git, and I'm used to Tortoise svn interface, so I'll try this one.

I saw you posted r129 in a fork, I don't know how to merge to the master. Do you need to make a pull request first?
I'll have to learn how git is working.

I see I can make test branches, so I can already submit partial work in progress changes. that's good to keep track on what I'm currently doing and other users can test it too.


Edit:
I'm currently using "Git for windows".
getting used to it.
I committed r129 and added a new e10s branch with my current changes.
Please read the changelog to see the progress/issues/etc.
Post #4
Edit / Delete
Pages : [1] Add a reply

Return to top